Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sony Dualsense and configs #1

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

NrettG
Copy link

@NrettG NrettG commented Mar 14, 2024

No description provided.

"pc_xinput": true,
"pc_steaminput": true,
"native_consoles": ["ps4","ps5"],
"_comment": "Wolf, the fighting alpha also has an xbox version available. Please fill out this section like you did with 3DS on variants.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d recommend creating another entry with the appropriate image for it since the Native Consoles would not match

That being said there is an argument to be made about all of the 3DS models being their own entry rather than having only one since there are all different hardware entirely, and not just extension port-related (Which would allow for the 3DS variants to include the Circle Pad Pro), so I’ll probably make a PR to fix that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3DS Fix PR: #15

}
],
"touch_screens": null,
"directional_buttons": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of a fight stick, directions are handled by the "Digital Stick" element (See https://github.com/Wolfy76700/ControllerDatabase/wiki/Controller-Definition#functions_digital_sticks_items_name)

@@ -0,0 +1,87 @@
{
"name": "Sony Dualsense Wireless Controller",
"functions": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"bluetooth": false,
"2_4ghz": false,
"rumble": null,
"digital_to_analog_conversion": null,
Copy link
Collaborator

@Wolfy76700 Wolfy76700 Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the stick have the capability to input Left Stick / Right Stick commands using the Digital Stick? If so then the Digital-to-Analog Conversion section should be filled in appropriately (See Keybox for example, https://github.com/Wolfy76700/ControllerDatabase/wiki/Controller-Definition#autogenerated_heading_15 for details)

Similarly the Digital-to-Analog Conversion for R2 and L2 should be documented

@@ -0,0 +1,94 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d recommend not using anything other than the following characters for folder/file names:

0123456789
abcdefghijklmnopqrstuvwxyz
_

Can you rename this controller’s folder to something like fightstick_alpha please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants