Skip to content

Commit

Permalink
Fix: Content-disposition filename matcher - improve regexp to work wi…
Browse files Browse the repository at this point in the history
…th white space + non latin filename in utf8
  • Loading branch information
maxime.abehserra committed Nov 13, 2024
1 parent 6b86177 commit bda1d4e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function normalizeMetadata(input?: File | Response | BufferLike | StreamL
}
if (input instanceof Response) {
const contentDisposition = input.headers.get("content-disposition")
const filename = contentDisposition && contentDisposition.match(/filename=['"]?([^'";]+)['"]?(?:;|$)/i)
const filename = contentDisposition && contentDisposition.match(/;\s*filename\*?\s*=\s*(?:UTF-\d+''|)["']?([^;"'\r\n]*)["']?(?:;|$)/i);
const urlName = filename && filename[1] || input.url && new URL(input.url).pathname.split("/").findLast(Boolean)
const decoded = urlName && decodeURIComponent(urlName)
// @ts-ignore allow coercion from null to zero
Expand Down
8 changes: 8 additions & 0 deletions test/metadata.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ Deno.test("normalizeMetadata guesses filename from Content-Disposition", () => {
assertEquals(metadata, { uncompressedSize: 0n, encodedName, nameIsBuffer: false })
})

Deno.test("normalizeMetadata guesses filename from non latin Content-Disposition", () => {
const metadata = normalizeMetadata(new Response("four", {
headers: { "content-disposition": "attachment; filename* = UTF-8''%CF%8C%CE%BD%CE%BF%CE%BC%CE%B1%20%CE%B1%CF%81%CF%87%CE%B5%CE%AF%CE%BF%CF%85.txt" }
}))
assertEquals(metadata, { uncompressedSize: 0n,encodedName: new TextEncoder().encode("όνομα αρχείου.txt"), nameIsBuffer: false })
})


Deno.test("normalizeMetadata guesses filename from a Response URL", () => {
const response = Object.create(Response.prototype, {
url: { get() { return "https://example.com/path/test.txt" } },
Expand Down

0 comments on commit bda1d4e

Please sign in to comment.