Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1897] nussknacker-components-api: remove dependency to async-http-client-ba… #7257

Merged
merged 3 commits into from
Nov 28, 2024
Merged

[NU-1897] nussknacker-components-api: remove dependency to async-http-client-ba… #7257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13dd682
nussknacker-components-api: remove dependency to async-http-client-ba…
arkadius Nov 27, 2024
3cca1e6
build fix
arkadius Nov 27, 2024
108551d
Changelog + MigrationGuide entries
arkadius Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,11 +1503,12 @@ lazy val liteK8sDeploymentManager = (project in lite("k8sDeploymentManager"))
libraryDependencies ++= {
Seq(
// From version 4.0.0 onwards, skuber uses pekko instead of akka, so we need to migrate to pekko first
"io.github.hagay3" %% "skuber" % "3.2" exclude ("commons-logging", "commons-logging"),
"com.github.julien-truffaut" %% "monocle-core" % monocleV,
"com.github.julien-truffaut" %% "monocle-macro" % monocleV,
"com.typesafe.akka" %% "akka-slf4j" % akkaV % Test,
"org.wiremock" % "wiremock" % wireMockV % Test,
"io.github.hagay3" %% "skuber" % "3.2" exclude ("commons-logging", "commons-logging"),
"com.github.julien-truffaut" %% "monocle-core" % monocleV,
"com.github.julien-truffaut" %% "monocle-macro" % monocleV,
"com.typesafe.akka" %% "akka-slf4j" % akkaV % Test,
"org.wiremock" % "wiremock" % wireMockV % Test,
"com.softwaremill.sttp.client3" %% "async-http-client-backend-future" % sttpV % Test,
)
},
buildAndImportRuntimeImageToK3d := {
Expand Down Expand Up @@ -1541,20 +1542,20 @@ lazy val componentsApi = (project in file("components-api"))
name := "nussknacker-components-api",
libraryDependencies ++= {
Seq(
"org.apache.commons" % "commons-text" % flinkCommonsTextV,
"org.typelevel" %% "cats-core" % catsV,
"com.beachape" %% "enumeratum" % enumeratumV,
"com.typesafe.scala-logging" %% "scala-logging" % scalaLoggingV,
"com.typesafe" % "config" % configV,
"org.semver4j" % "semver4j" % "5.4.0",
"javax.validation" % "validation-api" % javaxValidationApiV,
"org.scala-lang.modules" %% "scala-collection-compat" % scalaCollectionsCompatV,
"com.iheart" %% "ficus" % ficusV,
"org.springframework" % "spring-core" % springV,
"org.springframework" % "spring-expression" % springV % Test,
"com.google.code.findbugs" % "jsr305" % findBugsV,
"com.softwaremill.sttp.client3" %% "async-http-client-backend-future" % sttpV,
"org.scalatestplus" %% s"scalacheck-$scalaCheckVshort" % scalaTestPlusV % Test
"org.apache.commons" % "commons-text" % flinkCommonsTextV,
"org.typelevel" %% "cats-core" % catsV,
"com.beachape" %% "enumeratum" % enumeratumV,
"com.typesafe.scala-logging" %% "scala-logging" % scalaLoggingV,
"com.typesafe" % "config" % configV,
"org.semver4j" % "semver4j" % "5.4.0",
"javax.validation" % "validation-api" % javaxValidationApiV,
"org.scala-lang.modules" %% "scala-collection-compat" % scalaCollectionsCompatV,
"com.iheart" %% "ficus" % ficusV,
"org.springframework" % "spring-core" % springV,
"org.springframework" % "spring-expression" % springV % Test,
"com.google.code.findbugs" % "jsr305" % findBugsV,
"com.softwaremill.sttp.client3" %% "core" % sttpV,
"org.scalatestplus" %% s"scalacheck-$scalaCheckVshort" % scalaTestPlusV % Test
)
}
)
Expand Down Expand Up @@ -1686,9 +1687,10 @@ lazy val httpUtils = (project in utils("http-utils"))
name := "nussknacker-http-utils",
libraryDependencies ++= {
Seq(
"com.softwaremill.sttp.client3" %% "core" % sttpV,
"com.softwaremill.sttp.client3" %% "json-common" % sttpV,
"com.softwaremill.sttp.client3" %% "circe" % sttpV,
"com.softwaremill.sttp.client3" %% "core" % sttpV,
"com.softwaremill.sttp.client3" %% "json-common" % sttpV,
"com.softwaremill.sttp.client3" %% "circe" % sttpV,
"com.softwaremill.sttp.client3" %% "async-http-client-backend-future" % sttpV,
)
}
)
Expand Down
4 changes: 3 additions & 1 deletion docs/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
* [#7116](https://github.com/TouK/nussknacker/pull/7116) Improve missing Flink Kafka Source / Sink TypeInformation
* [#7123](https://github.com/TouK/nussknacker/pull/7123) Fix deployments for scenarios with dict editors after model reload
* [#7162](https://github.com/TouK/nussknacker/pull/7162) Component API enhancement: ability to access information about
expression parts used in SpEL template
expression parts used in SpEL template
* [#7257](https://github.com/TouK/nussknacker/pull/7257) components-api module: Replaced wide dependency to `async-http-client-backend-future`
by the narrowest possible dependency to sttp's core

## 1.18

Expand Down
2 changes: 2 additions & 0 deletions docs/MigrationGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ To see the biggest differences please consult the [changelog](Changelog.md).
* [#7116](https://github.com/TouK/nussknacker/pull/7116) Improve missing Flink Kafka Source / Sink TypeInformation
* We lost support for old ConsumerRecord constructor supported by Flink 1.14 / 1.15
* If you used Kafka source/sink components in your scenarios then state of these scenarios won't be restored
* [#7257](https://github.com/TouK/nussknacker/pull/7257) `components-api` doesn't depend on `async-http-client-backend-future`.
Instead, it depends on sttp's core. If your component rely on this, you should explicitly add dependency to `async-http-client-backend-future`.

## In version 1.18.0

Expand Down