Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1766] TypingResult: generic params canBeSubclassOf fix: collections covariance check #6570

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Aug 8, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius force-pushed the NU-1766-generic-param-canbesublass-fix branch from d0ca74c to 84a2d07 Compare August 8, 2024 13:11
@github-actions github-actions bot added the docs label Aug 8, 2024
@arkadius arkadius force-pushed the NU-1766-generic-param-canbesublass-fix branch from a82de41 to a27a30e Compare August 8, 2024 15:38
@arkadius arkadius marked this pull request as ready for review August 8, 2024 15:41
@arkadius arkadius force-pushed the NU-1766-generic-param-canbesublass-fix branch from a27a30e to d778081 Compare August 8, 2024 21:10
@arkadius arkadius merged commit a31bb0d into staging Aug 9, 2024
5 checks passed
@arkadius arkadius deleted the NU-1766-generic-param-canbesublass-fix branch August 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants