[NU-1609] fixed: Nu runtime memory leak #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrp
approved these changes
Apr 18, 2024
lciolecki
reviewed
Apr 18, 2024
| @@ -16,6 +16,7 @@ | |||
| * [#5843](https://github.com/TouK/nussknacker/pull/5843) Added new endpoint to provide statistics URL | |||
| * [#5873](https://github.com/TouK/nussknacker/pull/5873) Handle list of the anonymous statistic URLs, and send them in the interval | |||
| * [#5889](https://github.com/TouK/nussknacker/pull/5889) Decision Table component parameters validation improvement | |||
| * [#5898](https://github.com/TouK/nussknacker/pull/5898) fixed Nu runtime memory leak | |||
There was a problem hiding this comment.
we will fix this later
| // creation we clear the property (to not affect creating other /not existing currently/ IORuntimes). Note that | ||
| // we change here the global state, so this is not a bullet proof solution. | ||
| private def withDisableCatsTracingMode(create: => IORuntime): IORuntime = synchronized { | ||
| val tracingModePropertyName = "cats.effect.tracing.mode" |
There was a problem hiding this comment.
Can we declare this property at the beginning SynchronousExecutionContextAndIORuntime:
private val TracingModePropertyName = "cats.effect.tracing.mode"
?
There was a problem hiding this comment.
nope, IMO the current place of declaration is optimal
piotrp
pushed a commit
that referenced
this pull request
Apr 18, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
SynchronousExecutionContextAndIORuntimeprovides sync IORuntime. The runtime is rather dummy and there is no simple way to close it properly. We thought that there was no simple way to close it, but the closing is not required because it's a dummy. It figures out that it's not so true, because by default, during creation, MBean is registered. We don't need the monitoring functionality provided by the MBean, so we simply disable it before creating the sync IORuntime. Now, we consider it really a dummy one.Checklist before merge