Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements: Fixes and changes on TestScenarioRunner #4901

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Improvements: Fixes and changes on TestScenarioRunner #4901

merged 7 commits into from
Oct 20, 2023

Conversation

lciolecki
Copy link
Contributor

@lciolecki lciolecki commented Oct 19, 2023 •
edited
Loading

…ation collector, add missing tests

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@lciolecki lciolecki changed the title Improvements: Allowing run TestScenarioRunner in test mode with invoc… Improvements: Allowing run TestScenarioRunner in test mode with invocation collector, add missing tests Oct 19, 2023
@lciolecki lciolecki force-pushed the improvement/tests-scenario-runner-test-mode branch from 54ce5ee to f8b8c56 Compare October 19, 2023 10:48
@lciolecki lciolecki force-pushed the improvement/tests-scenario-runner-test-mode branch from 9542558 to e84aaa3 Compare October 19, 2023 18:57
@lciolecki lciolecki force-pushed the improvement/tests-scenario-runner-test-mode branch from 79b9000 to 695c8c5 Compare October 20, 2023 08:55
@github-actions github-actions bot added the docs label Oct 20, 2023
@lciolecki lciolecki changed the title Improvements: Allowing run TestScenarioRunner in test mode with invocation collector, add missing tests Improvements: Fixes and changes on TestScenarioRunner Oct 20, 2023
@lciolecki lciolecki force-pushed the improvement/tests-scenario-runner-test-mode branch from 38cead9 to 57bfdf2 Compare October 20, 2023 10:59
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Closed
@github-actions
Copy link
Contributor

created: #4907
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@lciolecki lciolecki merged commit 892d910 into staging Oct 20, 2023
17 checks passed
@lciolecki lciolecki deleted the improvement/tests-scenario-runner-test-mode branch October 20, 2023 12:26
philemone added a commit that referenced this pull request Oct 23, 2023
@philemone
Apply lcl #4901 change to 1.12
10db028
philemone pushed a commit that referenced this pull request Oct 23, 2023
@lciolecki @philemone
Improvements: Fixes and changes on TestScenarioRunner (#4901)
f3e98f5
philemone pushed a commit that referenced this pull request Nov 2, 2023
@lciolecki @philemone
Improvements: Fixes and changes on TestScenarioRunner (#4901)
b9a5be1
philemone pushed a commit that referenced this pull request Nov 10, 2023
@lciolecki @philemone
Improvements: Fixes and changes on TestScenarioRunner (#4901)
8e28131
philemone pushed a commit that referenced this pull request Nov 13, 2023
@lciolecki @philemone
Improvements: Fixes and changes on TestScenarioRunner (#4901)
97c4b75
arkadius added a commit that referenced this pull request Jul 8, 2024
@arkadius
[NU-1683] Fixes memory leak in test mechanism introduced in #4901
e3505e4
lukasz-bigorajski pushed a commit that referenced this pull request Jul 8, 2024
@arkadius
[NU-1683] Fixes memory leak in test mechanism introduced in #4901 (#6337
7869498 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lciolecki @arkadius