Merge branch 'refs/heads/release/1.18' into NU-1890-hide-categories-w…

…hen-there-is-only-one-category-available # Conflicts: # docs/Changelog.md
TouK · Nov 21, 2024 · 28de0bd · 28de0bd
2 parents dbfd5d7 + 6ff45eb
commit 28de0bd
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 19 deletions.
diff --git a/.github/workflows/benchmark-e2e.yml b/.github/workflows/benchmark-e2e.yml
@@ -18,7 +18,7 @@ jobs:
         run: |
           bash -c "export NUSSKNACKER_SCALA_VERSION=2.12 && sbt \"benchmarks/test:runMain pl.touk.nussknacker.engine.benchmarks.e2e.FlinkSteamingScenarioBenchmark 10000000\""
       - name: Store benchmark results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: benchmark-e2e.csv
           path: /tmp/benchmarkResult.csv
diff --git a/.github/workflows/benchmark-jmh.yml b/.github/workflows/benchmark-jmh.yml
@@ -17,7 +17,7 @@ jobs:
       - name: Run benchmarks
         run: sbt "benchmarks/jmh:run -i 8 -wi 3 -f1 -t1 -rf csv"
       - name: Store benchmark results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: jmh-result.csv
           path: benchmarks/jmh-result.csv
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -108,7 +108,7 @@ jobs:
         run:  find . -wholename "**/target/**/*" -printf '%P\0' | tar --null -C '.' --files-from=- -czf 'target.tgz'
       - name: Store target
         if: ${{ env.shouldPerformBackendBuild == 'true' }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: build-target
           path: target.tgz
@@ -158,7 +158,7 @@ jobs:
         shell: bash
         run:  tar -czf 'fe-dist.tgz' designer/client/dist designer/submodules/dist
       - name: Store dist
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: build-fe-dist
           path: fe-dist.tgz
@@ -185,7 +185,7 @@ jobs:
       - uses: coursier/setup-action@v1
         with:
           jvm: temurin:1.11.0.17
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: build-target
       - name: Untar artifacts
@@ -205,7 +205,7 @@ jobs:
         run: ./ciRunSbt.sh test
       - name: Test Report
         if: success() || failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: BackendTests-results-${{ matrix.scalaVersion }}
           path: '**/test-reports/*.xml'
@@ -239,7 +239,7 @@ jobs:
             ~/.sbt
           key: sbt-cache-${{ hashFiles('**/*.sbt') }}
           restore-keys: sbt
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: build-target
       - name: Untar artifacts
@@ -252,7 +252,7 @@ jobs:
         run: ./ciRunSbt.sh It/test
       - name: Test Report
         if: success() || failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: IntegrationTests-results-${{ matrix.scalaVersion }}
           path: '**/it-reports/*.xml'
@@ -286,7 +286,7 @@ jobs:
             ~/.sbt
           key: sbt-cache-${{ hashFiles('**/*.sbt') }}
           restore-keys: sbt
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: build-target
       - name: Untar artifacts
@@ -319,7 +319,7 @@ jobs:
           docker logs k3d-k3s-default-serverlb
       - name: Test Report
         if: success() || failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: SlowTests-results-${{ matrix.scalaVersion }}
           path: '**/test-reports/*.xml'
@@ -367,7 +367,7 @@ jobs:
         run: (cd designer/client; npm run test:unit)
       - name: Test Report
         if: ${{ env.shouldPerformFrontendTests == 'true' && (success() || failure()) }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: FrontendTests-results
           path: designer/client/junit.xml
@@ -415,15 +415,15 @@ jobs:
           npm ci --no-audit --prefix designer/client
           npm ci --no-audit --prefix designer/submodules
           rm -rf $npm_config_cache
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         if: ${{ env.shouldBuildImage == 'true' }}
         with:
           name: build-target
       - name: Untar artifacts
         if: ${{ env.shouldBuildImage == 'true' }}
         shell: bash
         run:  tar xfz target.tgz
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: build-fe-dist
       - name: Untar fe artifacts
@@ -470,13 +470,13 @@ jobs:
           npx start-server-and-test backend:docker ${{ env.BE_PORT }} start-prod 3000 test:e2e
       - name: Test Report
         if: success() || failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: CypressTests-results
           path: designer/client/cypress-test-results/*.xml
       - name: Store test results
         if: failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: e2e-test-results
           path: |
@@ -550,13 +550,13 @@ jobs:
             ~/.sbt
           key: sbt-cache-${{ hashFiles('**/*.sbt') }}
           restore-keys: sbt
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: build-target
       - name: Untar artifacts
         shell: bash
         run:  tar xfz target.tgz
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: build-fe-dist
       - name: Untar fe artifacts

diff --git a/designer/client/src/components/graph/node-modal/ParametersUtils.ts b/designer/client/src/components/graph/node-modal/ParametersUtils.ts
@@ -35,15 +35,15 @@ const parametersPath = (node) => {
 export function adjustParameters(node: NodeType, parameterDefinitions: UIParameter[]): AdjustReturn {
     const path = parametersPath(node);
 
-    if (!path) {
+    if (!path || !parameterDefinitions) {
         return { adjustedNode: node, unusedParameters: [] };
     }
 
     const currentNode = cloneDeep(node);
     const currentParameters = get(currentNode, path);
     //TODO: currently dynamic branch parameters are *not* supported...
     const adjustedParameters = parameterDefinitions
-        ?.filter((def) => !def.branchParam)
+        .filter((def) => !def.branchParam)
         .map((def) => {
             const currentParam = currentParameters.find((p) => p.name == def.name);
             const parameterFromDefinition = {

diff --git a/docs/Changelog.md b/docs/Changelog.md
@@ -106,6 +106,7 @@
 * [#7193](https://github.com/TouK/nussknacker/pull/7193) Provide tooltips to the scenarios list and scenario details elements
 * [#7187](https://github.com/TouK/nussknacker/pull/7187) Fix "Failed to get node validation" when using literal lists that mixes different types of elements
 * [#7183](https://github.com/TouK/nussknacker/pull/7183) Hide categories from a scenarios list and more scenario details when only one category is available
+* [#7192](https://github.com/TouK/nussknacker/pull/7192) Fix "Failed to get node validation" when opening node details referencing non-existing component
 
 ## 1.17