forked from TypesettingTools/Aegisub
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Factory #7
Open
Totto16
wants to merge
71
commits into
master
Choose a base branch
from
js-factory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
JS Factory #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Totto16
commented
Nov 9, 2023
•
edited
Loading
edited
- simple execution working
- reload, multiple instances etc.
- use the callbacks to actually do something
- made a seperate folder for factories and Automation4 - refactored the factory creation out of main.cpp
- small other fixes for ubuntu 23.10 >= - autoformat files
- fix lua type with boost 1.81.0
since it falsly assumes, it can construct an path from an initializer list of ints, but it doesn't prefer the initializer list, so it has to be explicitly typed
…cal variables by value, class members by reference - in some places I now use explicit names in the capture group, especially in lua files
… lua scripts run asynchronous
…d desktop file to be an allowed export!
- made a seperate folder for factories and Automation4 - refactored the factory creation out of main.cpp
- add simple js factory, it's not able to do much atm, but thats WIP - add v8 and node dependency lookup - add test to test for correct node js version and if it compiles correctly
add simple exports and exitCode getter from js into c++
…sub uses many internals, that are only there in lua 5.1
…from the packager (me in the selfbuilt case xD - fix def installer by not installing into ~/.aegisub/ but /usr/share/aegisub - set prefix to /sur in compile script
- fix meson nodejs detection, by not using missing folder
- update idl generator - add first generated dummy file - add meson.build custom_target to generate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.