Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with the Rocket v0.5-rc branch #4

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mentaljam
Copy link

This is a draft which main purpose is to prepare for coming Rocket changes which are in the v0.5-rc branch. Also the PR provides a new crate rocket_okapi_ui with functionality to embed Swagger UI into the application which is moved from the swagger_ui mod.

@TotalKrill
Copy link
Owner

I do like how the UI part is moved out! hopefully it would make it better to provide alternative openapi UIs later

@ralpha
Copy link

ralpha commented Sep 10, 2021

@mentaljam In GREsau/okapi master I have changed the UI part. Instead of putting it in a separate crate I opted for putting it under a feature flag.
I also added RapiDoc as an alternative to Swagger UI, also under a feature flag.
So this means that the UI is still part of the rocket-okapi crate but does not get included into the executable if the flag is not set.
Adding your own UI is still possible (it always was). Maybe in the future we can still separate the UI into its own crate.
If you have some feedback, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants