Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SortExpression should be a struct, not a class #331

Closed
Grauenwolf opened this issue Jan 14, 2020 · 3 comments
Closed

SortExpression should be a struct, not a class #331

Grauenwolf opened this issue Jan 14, 2020 · 3 comments
Assignees
@Grauenwolf
Milestone
Tortuga Chain 3.2

Comments

@Grauenwolf
Copy link
Collaborator

There is no reason to allocate a whole object for this simple container.
@Grauenwolf Grauenwolf added this to the Tortuga Chain 3.2 milestone Jan 14, 2020
@Grauenwolf
Copy link
Collaborator Author

Grauenwolf commented Jan 21, 2020 •
edited
Loading

There is a race condition in SortExpression. It assumes that SortExpression will never be reused so it makes hidden changes.

Obviously this is bad, but we don't want to make BuildOrderByClause allocate more memory if we can avoid it.

@Grauenwolf Grauenwolf self-assigned this Jan 21, 2020
@Grauenwolf Grauenwolf modified the milestone: Tortuga Chain 3.2 Jan 28, 2020
@Grauenwolf
Copy link
Collaborator Author

That was stupid. It never actually used the hidden field.

@Grauenwolf
Copy link
Collaborator Author

Adding support for "columnName DESC" while we're here.

Grauenwolf added a commit that referenced this issue Jan 29, 2020
@Grauenwolf
SortExpression should be a struct, not a class #331
982dc49
@Grauenwolf Grauenwolf mentioned this issue Jan 29, 2020
Merged
Grauenwolf added a commit that referenced this issue Jan 31, 2020
@Grauenwolf
Merge pull request #337 from docevaad/SortExpression-331
1ba3c0d 
SortExpression should be a struct, not a class #331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Grauenwolf Grauenwolf

Labels
None yet
Projects
None yet
Milestone
Tortuga Chain 3.2
Development

No branches or pull requests
1 participant
@Grauenwolf