update account data only when necessary

Topheee · Apr 27, 2023 · e1eb69c · e1eb69c
1 parent 01abe16
commit e1eb69c
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/MatrixSDK/MXSession.m b/MatrixSDK/MXSession.m
@@ -4773,21 +4773,26 @@ - (void)removeBreadcrumbWithRoomWithId:(NSString *)roomId
     if (index != NSNotFound)
     {
         [recentRoomIds removeObjectAtIndex:index];
+
+        [self setAccountData:@{kMXAccountDataTypeRecentRoomsKey : recentRoomIds}
+                     forType:kMXAccountDataTypeBreadcrumbs
+                      success:^{
+             if (success)
+             {
+                 success();
+             }
+         } failure:^(NSError *error) {
+             if (failure)
+             {
+                 failure(error);
+             }
+         }];
+    } else {
+        if (success)
+        {
+            success();
+        }
     }
-
-    [self setAccountData:@{kMXAccountDataTypeRecentRoomsKey : recentRoomIds}
-                 forType:kMXAccountDataTypeBreadcrumbs
-                  success:^{
-         if (success)
-         {
-             success();
-         }
-     } failure:^(NSError *error) {
-         if (failure)
-         {
-             failure(error);
-         }
-     }];
 }
 
 #pragma mark - Homeserver information