Fix string memory leak in Switch.writeFileSync()

TooTallNate · Oct 6, 2023 · aa87ace · aa87ace
1 parent cf578d8
commit aa87ace
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/grumpy-paws-film.md b/.changeset/grumpy-paws-film.md
@@ -0,0 +1,5 @@
+---
+'nxjs-runtime': patch
+---
+
+Fix string memory leak in `Switch.writeFileSync()`
diff --git a/source/fs.c b/source/fs.c
@@ -200,12 +200,12 @@ JSValue nx_write_file_sync(JSContext *ctx, JSValueConst this_val, int argc, JSVa
         JS_FreeCString(ctx, filename);
         return JS_EXCEPTION;
     }
+    JS_FreeCString(ctx, filename);
 
     size_t size;
     uint8_t *buffer = JS_GetArrayBuffer(ctx, &size, argv[1]);
     if (buffer == NULL)
     {
-        JS_FreeCString(ctx, filename);
         fclose(file);
         JS_ThrowOutOfMemory(ctx);
         return JS_EXCEPTION;
@@ -216,7 +216,6 @@ JSValue nx_write_file_sync(JSContext *ctx, JSValueConst this_val, int argc, JSVa
 
     if (result != size)
     {
-        JS_FreeCString(ctx, filename);
         JS_ThrowTypeError(ctx, "Failed to write entire file. Got %lu, expected %lu", result, result);
         return JS_EXCEPTION;
     }