Skip to content

Commit

Permalink
Updated node version to 20?
Browse files Browse the repository at this point in the history
  • Loading branch information
TomyBDev committed Feb 10, 2024
1 parent 8854f94 commit 26b981b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-deploy-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,17 @@ jobs:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
- name: Install dependencies
run: npm ci
- name: Install Playwright Browsers
run: npx playwright install --with-deps
- name: Run Playwright tests
run: npx playwright test
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down
2 changes: 1 addition & 1 deletion tests/example.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test('check social buttons', async ({ page }) => {

// Start waiting for new page before clicking. Note no await.
const pagePromise = context.waitForEvent('page');
await page.getByRole('button', { name: 'LinkedIn' }).click({ force: true });
await page.getByRole('button', { name: 'LinkedIn' }).click();
const newPage = await pagePromise;
await newPage.waitForLoadState();
await expect(newPage).toHaveURL(/www.linkedin.com/);
Expand Down

0 comments on commit 26b981b

Please sign in to comment.