Fixes issue TestQualityMeasures' object has no attribute 'id_coins_sliced' #1710

[MargaretDuff]

Describe your changes

Added skip if no scipy to the new tests

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/

Link relevant issues

Closes #1710

Checklist when you are ready to request a review

• I have performed a self-review of my code
• I have added docstrings in line with the guidance in the developer guide
• I have implemented unit tests that cover any new or modified functionality
• CHANGELOG.md has been updated with any functionality change
• Request review from all relevant developers
• Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

• The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
• I confirm that the contribution does not violate any intellectual property rights of third parties

[paskino]

Looks good to me.
I guess we could skip the whole class with one skipIf above the class definition, but I haven't tested it.

I fixed the build issue on SIRF by not running this test in SIRF-SuperBuild paskino/SIRF-SuperBuild@c017a59

[casperdcl]

btw, why isn't scikit-image a hard dependency?

[MargaretDuff]

btw, why isn't scikit-image a hard dependency?

I don't know - is it used elsewhere in CIL? If it is automatically installed with the CIL conda build I presume the skip decorator was there for SIRF reasons?

[paskino]

btw, why isn't scikit-image a hard dependency?

because we only need it for this test.

[KrisThielemans]

Does this mean we can add scikit-image just to run the tests.

We have
https://github.com/SyneRBI/SIRF-SuperBuild/blob/master/docker/requirements-travis.txt
(surely to be renamed) where this could be added. conda recipes allow you to specify this, but for the SuperBuild, we have to do this by hand. Obviously, ideally the SIRF-SuperBuild would get this information from CIL, but that isn't so easy to set-up. SyneRBI/SIRF-SuperBuild#493

[paskino]

@KrisThielemans this PR fixes the unittest if scikit-image isn't installed. Once we tag the new CIL release (probably next week? @gfardell ) we can then remove the added scikit-image from the SuperBuild requirements.txt

[KrisThielemans]

Once we tag the new CIL release (probably next week? @gfardell ) we can then remove the added scikit-image from the SuperBuild requirements.txt

why would we? If it's installed, the test will run, which has to be a good thing.