Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra ` #16

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Remove the extra ` #16

merged 1 commit into from
Nov 6, 2021

Conversation

yihui
Copy link
Contributor

@yihui yihui commented Oct 16, 2021

yihui/knitr#2057

It will be great if you could make a CRAN release at some time after merging this PR. Thank you!

@TomKellyGenetics
Copy link
Owner

Thank you for notifying us @yihui! I received your email and have planned to amend this on the next CRAN release. Since expected updates to dependencies discussed in #1 are now available, I will be submitting a release in the near future.

Sorry it may some time and for the delayed response. I developed this package in my previous position and I am busy with the duties of my new job.

@TomKellyGenetics TomKellyGenetics merged commit 50e76a7 into TomKellyGenetics:master Nov 6, 2021
@yihui
Copy link
Contributor Author

yihui commented Nov 6, 2021

No worries at all! Please take your time. Thanks!

@yihui yihui deleted the patch-1 branch November 6, 2021 14:30
TomKellyGenetics pushed a commit that referenced this pull request May 9, 2022
@TomKellyGenetics
Copy link
Owner

I've committed this change to master here (thanks for the reminder by email). It will be resolved in the next release on CRAN.
7e3e007

Sorry it appears this PR was merged into version 0.3.10 but was not included in the development version so version 0.4.2 which includes major changes did not resolve the issue. https://github.com/TomKellyGenetics/leiden/releases/tag/0.4.2

Apologies for the confusion, this is a result of changes that depended on updates to igraph which took a long time to release. #1

@yihui
Copy link
Contributor Author

yihui commented Nov 6, 2023

Oh I have completely forgotten that I had a PR here :)

No worries, and thanks!

@TomKellyGenetics
Copy link
Owner

Release v0.4.3.1 which resolves this is on it's way to CRAN

@yihui
Copy link
Contributor Author

yihui commented Nov 8, 2023

Perfect!

@TomKellyGenetics
Copy link
Owner

Live on CRAN today. Minor delays due to updates in their citation checks and reverse dependencies failing with Seurat v4.4.0. Seems to be an unrelated issue to changes in this package so CRAN overlords approved it.

@yihui
Copy link
Contributor Author

yihui commented Nov 19, 2023

Great! Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants