Fixed tie-vote handling #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh shoot, you're right I didn't notice that. I think I'd prefer if they all showed the emoji in the text so they line up with when a button is actually chosen. If you want to put that in this PR feel free, otherwise I'll just create another issue for it since it's not a huge deal and I'll just go ahead and merge this one in |
|
So it's okay if
|
|
Yes I'd prefer if it shows the emoji like it does for successful votes
|
Made button name formatting consistent (except in "test()"). Also, fixed the formatting of "Game Boy", "Mastodon", etc. except where it would break the code.
|
OK, the emoji formatting should be consistent now, along with some other things that were bugging me but didn't affect the program logic (gameboy -> Game Boy, mastodon -> Mastodon, etc.) Also, I folded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6
I'm confident that this code properly handles tie votes now by choosing a random button out of those that tied. However, I'm not so sure about the formatting of
top_result, sinceself.random_button()andself.take_actionuse different strings for the buttons.