Add new addresses flash borrowers #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main from bgd-labs
defijesus
requested changes
Sep 17, 2024
|
|
||
| ## Simple Summary | ||
|
|
||
| This AIP updated and extends existing whitelisted flashBorrowers addresses to recently deployed instances of Aave v3 on Ethereum. |
There was a problem hiding this comment.
Suggested change
| This AIP updated and extends existing whitelisted flashBorrowers addresses to recently deployed instances of Aave v3 on Ethereum. | |
| This AIP updates and extends existing whitelisted flashBorrowers addresses to recently deployed instances of Aave v3 on Ethereum. |
As of right now the described targeted intances are confusing, it specifies the recently deployed instances while the payload also targets ethereum v3 main instance. My suggestion is to specify of all targeted instances.
| */ | ||
| contract AaveV3Ethereum_AddFlashBorrowers_20240906 is IProposalGenericExecutor { | ||
| address public constant CIAN_FLASH_LOAN_HELPER = 0x49d9409111a6363d82C4371fFa43fAEA660C917B; | ||
|
|
There was a problem hiding this comment.
according to the specification, shouldnt this instance also include the rest of the flash borrowers included in other ethereum instances? (Lido for example)
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Luigy-Lemon
reviewed
Sep 18, 2024
| */ | ||
| contract AaveV3Ethereum_AddFlashBorrowers_20240906 is IProposalGenericExecutor { | ||
| address public constant CIAN_FLASH_LOAN_HELPER = 0x49d9409111a6363d82C4371fFa43fAEA660C917B; | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
LucasWongC
merged commit a7acbf1
into
TokenLogic-com-au:add-new-flash-borrowers
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.