Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce similar ambiguities #68

Merged
merged 8 commits into from
Feb 22, 2021
Merged

Reduce similar ambiguities #68

merged 8 commits into from
Feb 22, 2021

Conversation

Tokazama
Copy link
Owner

This doesn't solve all the issues related to similar, but it handles problems directly in this package. NamedDims and Metadata still have issues upstream.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #68 (9693bb7) into master (5eacd21) will increase coverage by 2.40%.
The diff coverage is 58.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   65.25%   67.65%   +2.40%     
==========================================
  Files          27       29       +2     
  Lines        2029     2288     +259     
==========================================
+ Hits         1324     1548     +224     
- Misses        705      740      +35     
Impacted Files Coverage Δ
src/AxisIndices.jl 40.00% <ø> (-5.57%) ⬇️
src/centered_axis.jl 59.42% <ø> (-0.58%) ⬇️
src/combine.jl 48.03% <ø> (+3.09%) ⬆️
src/named.jl 56.06% <ø> (+5.63%) ⬆️
src/padded_axis.jl 63.70% <0.00%> (+2.36%) ⬆️
src/identity_axis.jl 40.90% <25.00%> (-2.47%) ⬇️
src/similar.jl 35.84% <35.84%> (ø)
src/errors.jl 54.54% <50.00%> (-1.02%) ⬇️
src/axis.jl 62.89% <52.77%> (+1.90%) ⬆️
src/utils.jl 55.17% <55.17%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3ce1f...9693bb7. Read the comment docs.

@Tokazama Tokazama merged commit add8f06 into master Feb 22, 2021
@Tokazama Tokazama deleted the similar branch February 22, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant