fix: Make it possible again to compile cmp.c as C++.

[iphydf]

This change is 

[JFreegman]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @iphydf)

---

cmp.c line 144 at r1 (raw file):

static uint64_t be64(uint64_t x) {
  if (!is_bigendian())
    return ((uint64_t)be32((uint32_t)(x & 0xffffffff)) << 32) | (uint64_t)be32((uint32_t)(x >> 32));

A simple call to be64() ends up making a call stack of 14. Is this really an improvement? Does it matter for our use case?

[iphydf]

Reviewable status: 0 of 1 approvals obtained (waiting on @JFreegman)

---

cmp.c line 144 at r1 (raw file):

Previously, JFreegman wrote…

A simple call to be64() ends up making a call stack of 15. Is this really an improvement? Does it matter for our use case?

Is your concern code clarity or performance? If it's the latter: the code generated for the function before and after is exactly the same: 1 instruction bswapq. If it's the former: how would you write it to be clearer?

[JFreegman]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @iphydf)

---

cmp.c line 144 at r1 (raw file):

Previously, iphydf wrote…

Is your concern code clarity or performance? If it's the latter: the code generated for the function before and after is exactly the same: 1 instruction bswapq. If it's the former: how would you write it to be clearer?

My concern was with performance. If that's the case, ignore this comment.