Simplify Travis CI builds. #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
simplify-travis
branch
29 times, most recently
from
9634b42 to
d703c92
Compare
iphydf
force-pushed
the
simplify-travis
branch
10 times, most recently
from
c01894f to
4349346
Compare
iphydf
force-pushed
the
simplify-travis
branch
2 times, most recently
from
d29286a to
8bfd522
Compare
iphydf
force-pushed
the
simplify-travis
branch
3 times, most recently
from
e0454d9 to
f558b6a
Compare
|
Reviewed 35 of 36 files at r1, 2 of 2 files at r2, 1 of 1 files at r3. .travis/cmake-linux, line 15 at r2 (raw file):
Stray whitespace Comments from Reviewable |
complete! 1 of 1 LGTMs obtained
nurupo
reviewed
Jul 1, 2018
| @@ -79,7 +83,7 @@ build() | |||
| if [ "${ALLOW_TEST_FAILURE}" = "true" ]; then | |||
| set +e | |||
| fi | |||
| cmake --build . --target test | |||
| cmake --build . --target test -- ARGS="-j50" | |||
|
Review status: .travis/cmake-linux, line 15 at r2 (raw file): Previously, robinlinden (Robin Lindén) wrote…
Done. other/docker/windows/build_toxcore.sh, line 86 at r4 (raw file): Previously, nurupo wrote…
Yes, 50 is greater than the number of tests we have at the moment, and up to 50 is probably easily ok. These tests sleep almost all the time, so running them all in parallel doesn't cost much cpu but saves a whole lot of time. Comments from Reviewable |
Have one script per build. This means more duplication between the scripts, but it's much easier to understand and to run locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have one script per build. This means more duplication between the
scripts, but it's much easier to understand and to run locally.
I mostly didn't touch the freebsd stuff. I may move that at some point in the future. It's using
sourceas done byphasetoo cleverly, so I couldn't easily break it out of the current place.This change is