Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifying comment to cryptpacket_received function. #859

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

hqwrong
Copy link

@hqwrong hqwrong commented Apr 2, 2018

see #851


This change is Reviewable

@sudden6
Copy link

sudden6 commented Apr 2, 2018

Can you limit the line length to the same with as the rest of the code uses?

@hqwrong
Copy link
Author

hqwrong commented Apr 3, 2018

@sudden6 done

@sudden6
Copy link

sudden6 commented Apr 3, 2018

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


toxcore/net_crypto.c, line 2759 at r1 (raw file):

 * return 0 on success.
 *
 * Note: The condition `buffer_end - buffer_start < pakcet_number - buffer_start` is

typo packet_number


toxcore/net_crypto.c, line 2765 at r1 (raw file):

 * It CANNOT be simplified to `packet_number < buffer_start`, as it will fail
 * when `buffer_end < buffer_start`.
 *

please remove empty lines


Comments from Reviewable

@sudden6
Copy link

sudden6 commented Apr 3, 2018

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 7fa0c89 into TokTok:master Apr 3, 2018
@iphydf iphydf changed the title add comment to func cryptpacket_received Add clarifying comment to cryptpacket_received function. Apr 3, 2018
@iphydf iphydf added this to the v0.2.2 milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants