-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move system header includes from network.h to network.c #822
Conversation
494c64d
to
0971d3b
Compare
7d246b0
to
1ed247f
Compare
This looks like something that might be worth testing on all CI configurations once this is ready for merge, as we had quite the trouble with all those OS-specific network includes before. |
Yes, I will do that once 0.2.0 is released. |
1ed247f
to
bd307a2
Compare
769fc02
to
e82b21a
Compare
@nurupo done. |
73ed2e7
to
bd78346
Compare
cd45eac
to
01f974c
Compare
feb00f6
to
006e4bd
Compare
006e4bd
to
8307f74
Compare
8307f74
to
6921af9
Compare
6921af9
to
1464566
Compare
Reviewed 33 of 34 files at r1. toxcore/network.c, line 64 at r1 (raw file):
add a guard comment like above? toxcore/TCP_server.c, line 251 at r1 (raw file):
const Comments from Reviewable |
1464566
to
5300840
Compare
71fa12c
to
9e4570a
Compare
Review status: 25 of 34 files reviewed at latest revision, 2 unresolved discussions. toxcore/network.c, line 64 at r1 (raw file): Previously, sudden6 wrote…
Done. toxcore/TCP_server.c, line 251 at r1 (raw file): Previously, sudden6 wrote…
Done. Comments from Reviewable |
Reviewed 3 of 3 files at r2, 6 of 6 files at r3. Comments from Reviewable |
9e4570a
to
be797d4
Compare
v0.2.3 **Merged PRs:** - [TokTok#951] Only run astyle if the astyle binary exists. - [TokTok#950] Remove utils.c and utils.h from toxencryptsave build. - [TokTok#949] Fixes to the imported sodium sources to compile without warnings. - [TokTok#948] Add a MAX_HOSTNAME_LENGTH constant. - [TokTok#947] Remove the format test. - [TokTok#937] Add new Circle CI configuration. - [TokTok#935] Add a test for double conference invite. - [TokTok#933] Add Logger to various net_crypto functions, and add `const` to Logger where possible. - [TokTok#931] Avoid conditional-uninitialised warning for tcp test. - [TokTok#930] Disable UDP when proxy is enabled. - [TokTok#928] Use clang-format for C++ code. - [TokTok#927] Add assertions to bootstrap tests for correct connection type. - [TokTok#926] Make NULL options behave the same as default options. - [TokTok#925] Add tests for what happens when passing an invalid proxy host. - [TokTok#924] Make the net_crypto connection state an enum. - [TokTok#922] Clarify/Improve test_some test - [TokTok#921] Beginnings of a TCP_test.c overhaul - [TokTok#920] Add test for creating multiple conferences in one tox. - [TokTok#918] Merge irungentoo/master into toktok - [TokTok#917] Add random testing program. - [TokTok#916] Fix linking with address sanitizer. - [TokTok#915] Remove resource_leak_test. - [TokTok#914] Make dht_test more stable. - [TokTok#913] Minor cleanup: return early on error condition. - [TokTok#906] Sort bazel build file according to buildifier standard. - [TokTok#905] In DEBUG mode, make toxcore crash on signed integer overflow. - [TokTok#902] Log only the filename, not the full path in LOGGER. - [TokTok#899] Fix macOS macro because of GNU Mach - [TokTok#898] Fix enumeration of Crypto_Connection instances - [TokTok#897] Fix ipport_isset: port 0 is not a valid port. - [TokTok#894] Fix logging related crash in bootstrap node - [TokTok#893] Fix bootstrap crashes, still - [TokTok#892] Add empty logger to DHT bootstrap daemons. - [TokTok#887] Fix FreeBSD build on Travis - [TokTok#884] Fix the often call of event tox_friend_connection_status - [TokTok#883] Make toxcore compile on BSD - [TokTok#878] fix DHT_bootstrap key loading - [TokTok#877] Add minitox to under "Other resources" section in the README - [TokTok#875] Make bootstrap daemon use toxcore's version - [TokTok#867] Improve network error reporting on Windows - [TokTok#841] Only check full rtp offset if RTP_LARGE_FRAME is set - [TokTok#823] Finish @Diadlo's network Family abstraction. - [TokTok#822] Move system header includes from network.h to network.c
v0.2.3 **Merged PRs:** - [TokTok#951] Only run astyle if the astyle binary exists. - [TokTok#950] Remove utils.c and utils.h from toxencryptsave build. - [TokTok#949] Fixes to the imported sodium sources to compile without warnings. - [TokTok#948] Add a MAX_HOSTNAME_LENGTH constant. - [TokTok#947] Remove the format test. - [TokTok#937] Add new Circle CI configuration. - [TokTok#935] Add a test for double conference invite. - [TokTok#933] Add Logger to various net_crypto functions, and add `const` to Logger where possible. - [TokTok#931] Avoid conditional-uninitialised warning for tcp test. - [TokTok#930] Disable UDP when proxy is enabled. - [TokTok#928] Use clang-format for C++ code. - [TokTok#927] Add assertions to bootstrap tests for correct connection type. - [TokTok#926] Make NULL options behave the same as default options. - [TokTok#925] Add tests for what happens when passing an invalid proxy host. - [TokTok#924] Make the net_crypto connection state an enum. - [TokTok#922] Clarify/Improve test_some test - [TokTok#921] Beginnings of a TCP_test.c overhaul - [TokTok#920] Add test for creating multiple conferences in one tox. - [TokTok#918] Merge irungentoo/master into toktok - [TokTok#917] Add random testing program. - [TokTok#916] Fix linking with address sanitizer. - [TokTok#915] Remove resource_leak_test. - [TokTok#914] Make dht_test more stable. - [TokTok#913] Minor cleanup: return early on error condition. - [TokTok#906] Sort bazel build file according to buildifier standard. - [TokTok#905] In DEBUG mode, make toxcore crash on signed integer overflow. - [TokTok#902] Log only the filename, not the full path in LOGGER. - [TokTok#899] Fix macOS macro because of GNU Mach - [TokTok#898] Fix enumeration of Crypto_Connection instances - [TokTok#897] Fix ipport_isset: port 0 is not a valid port. - [TokTok#894] Fix logging related crash in bootstrap node - [TokTok#893] Fix bootstrap crashes, still - [TokTok#892] Add empty logger to DHT bootstrap daemons. - [TokTok#887] Fix FreeBSD build on Travis - [TokTok#884] Fix the often call of event tox_friend_connection_status - [TokTok#883] Make toxcore compile on BSD - [TokTok#878] fix DHT_bootstrap key loading - [TokTok#877] Add minitox to under "Other resources" section in the README - [TokTok#875] Make bootstrap daemon use toxcore's version - [TokTok#867] Improve network error reporting on Windows - [TokTok#841] Only check full rtp offset if RTP_LARGE_FRAME is set - [TokTok#823] Finish @Diadlo's network Family abstraction. - [TokTok#822] Move system header includes from network.h to network.c
This change is