Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match parameter names in declarations with their definitions. #81

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 31, 2016

The parameter names were taken from function definitions to update the names in
function declarations (prototypes).


This change is Reviewable

@GrayHatter
Copy link

:lgtm:

:shipit:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@GrayHatter
Copy link

:lgtm_cancel:

That's a lie tox.h.in and toxav.h.in


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf iphydf force-pushed the param-names branch 2 times, most recently from f732a38 to 9e6e8af Compare September 1, 2016 09:00
@iphydf
Copy link
Member Author

iphydf commented Sep 1, 2016

Done.


Review status: 3 of 6 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Diadlo
Copy link

Diadlo commented Sep 1, 2016

Reviewed 3 of 5 files at r1, 3 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


toxcore/tox.c, line 143 [r2] (raw file):

}

void tox_options_set_savedata_data(struct Tox_Options *options, const uint8_t *savedata_data, size_t savedata_length)

In tox.h we have const uint8_t *data as second parameter, and size_t length as last.


Comments from Reviewable

@Diadlo
Copy link

Diadlo commented Sep 1, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.


toxcore/tox.c, line 143 [r2] (raw file):

Previously, Diadlo (Diadlo) wrote…

In tox.h we have const uint8_t *data as second parameter, and size_t length as last.

Are you sure, that `savedata_data` is correct name?

Comments from Reviewable

The parameter names were taken from function definitions to update the names in
function declarations (prototypes).
@iphydf
Copy link
Member Author

iphydf commented Sep 1, 2016

Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion.


toxcore/tox.c, line 143 [r2] (raw file):

Previously, Diadlo (Diadlo) wrote…

Do you sure, that savedata_data is correct name?

Done.

Comments from Reviewable

@Diadlo
Copy link

Diadlo commented Sep 1, 2016

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf assigned Diadlo and unassigned GrayHatter Sep 1, 2016
@iphydf iphydf closed this Sep 1, 2016
@iphydf iphydf deleted the param-names branch September 1, 2016 14:21
@iphydf iphydf merged commit 45d1f9a into TokTok:master Sep 1, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants