Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TCP_Client_Connection a module-private type. #674

Merged
merged 1 commit into from
Jan 14, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 13, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 13, 2018
@e0ff
Copy link
Member

e0ff commented Jan 13, 2018

Reviewed 3 of 4 files at r1.
Review status: 3 of 4 files reviewed at latest revision, 5 unresolved discussions, some commit checks broke.


toxcore/TCP_client.c, line 87 at r1 (raw file):

};

const uint8_t *tcp_con_public_key(const TCP_Client_Connection *con) {

tcp_get_con_public_key


toxcore/TCP_client.c, line 91 at r1 (raw file):

}

IP_Port tcp_con_ip_port(const TCP_Client_Connection *con) {

tcp_get_con_ip_port


toxcore/TCP_client.c, line 95 at r1 (raw file):

}

TCP_CLIENT_STATUS tcp_con_status(const TCP_Client_Connection *con) { return con->status; }

tcp_get_con_status


toxcore/TCP_client.c, line 96 at r1 (raw file):

TCP_CLIENT_STATUS tcp_con_status(const TCP_Client_Connection *con) { return con->status; }
void *tcp_con_custom_object(const TCP_Client_Connection *con) { return con->custom_object; }

tcp_con_get_custom_object


toxcore/TCP_client.c, line 97 at r1 (raw file):

TCP_CLIENT_STATUS tcp_con_status(const TCP_Client_Connection *con) { return con->status; }
void *tcp_con_custom_object(const TCP_Client_Connection *con) { return con->custom_object; }
uint32_t tcp_con_custom_uint(const TCP_Client_Connection *con) { return con->custom_uint; }

tcp_get_con_custom_uint


Comments from Reviewable

@iphydf
Copy link
Member Author

iphydf commented Jan 13, 2018

Review status: 3 of 4 files reviewed at latest revision, 5 unresolved discussions, some commit checks broke.


toxcore/TCP_client.c, line 87 at r1 (raw file):

Previously, endoffile78 (Endoffile) wrote…

tcp_get_con_public_key

Actually: tcp_con_get_public_key, or even tcp_client_get_public_key. I'm going over all the names later with apidsl.


Comments from Reviewable

@e0ff
Copy link
Member

e0ff commented Jan 13, 2018

:lgtm_strong:


Reviewed 1 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@iphydf iphydf force-pushed the adt-tcp-client branch 5 times, most recently from b2986b0 to 167c838 Compare January 14, 2018 15:02
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
@iphydf iphydf merged commit bacd74c into TokTok:master Jan 14, 2018
@iphydf iphydf deleted the adt-tcp-client branch January 14, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants