-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.1.11 #638
Release v0.1.11 #638
Conversation
Is it normal/intended that the FreeBSD script runs cmake for about 10 times and only then runs make? |
8b91b53
to
44b5c55
Compare
LGTM :) |
Reviewed 6 of 6 files at r1. Comments from Reviewable |
Thank you for all your hard work. |
@sudden6 yeah, that's normal. We also do this on Linux, Windows, etc., it's not just FreeBSD that runs cmake multiple times. Here is the code that is responsible for that c-toxcore/other/travis/toxcore-script Lines 6 to 23 in b39cc55
toxcore-script script, and here is the commit that added it 0a61d11. It's purpose is to check if certain cmake argument combinations result in a failure when generating the Makefile out of CMakeLists.txt, e.g. incompatible cmake arguments, etc. Can't find the PR that added it though, for some reason the GitHub web page for the commit links to a PR in zoff99's repo instead of the PR in this repo that have added the commit, must be GitHub bug.
|
@nurupo thanks for clarifying :) |
Green :) let's make the release. |
This change is