Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.1.11 #638

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Release v0.1.11 #638

merged 1 commit into from
Dec 27, 2017

Conversation

robinlinden
Copy link
Member

@robinlinden robinlinden commented Dec 17, 2017

This change is Reviewable

@robinlinden robinlinden added this to the v0.1.11 milestone Dec 17, 2017
@sudden6
Copy link

sudden6 commented Dec 17, 2017

Is it normal/intended that the FreeBSD script runs cmake for about 10 times and only then runs make?

@robinlinden robinlinden force-pushed the 0.1.11 branch 2 times, most recently from 8b91b53 to 44b5c55 Compare December 17, 2017 19:22
@SkyzohKey
Copy link

LGTM :)

@sudden6
Copy link

sudden6 commented Dec 23, 2017

:lgtm_strong:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@robinlinden
Copy link
Member Author

@nurupo Can you have a look at @sudden6's comment?

@im-grey
Copy link

im-grey commented Dec 23, 2017

Thank you for all your hard work.

@nurupo
Copy link
Member

nurupo commented Dec 24, 2017

@sudden6 yeah, that's normal. We also do this on Linux, Windows, etc., it's not just FreeBSD that runs cmake multiple times. Here is the code that is responsible for that

set_opt() {
opts="$opts -D$1="`expr ON \& \( $i % 2 \) \| OFF`
set +e # result can be 0
i=`expr $i / 2`
set -e
}
# Try some combinations of cmake options.
for i in `seq 0 7`; do
set +x
opts="$CMAKE_EXTRA_FLAGS -DWARNINGS=OFF"
set_opt STRICT_ABI
set_opt ENABLE_STATIC
set_opt ENABLE_SHARED
set -x
RUN $CMAKE -B$BUILD_DIR -H. $opts
RUN rm -rf $BUILD_DIR
done
, you can see that it's in a platform-independent toxcore-script script, and here is the commit that added it 0a61d11. It's purpose is to check if certain cmake argument combinations result in a failure when generating the Makefile out of CMakeLists.txt, e.g. incompatible cmake arguments, etc. Can't find the PR that added it though, for some reason the GitHub web page for the commit links to a PR in zoff99's repo instead of the PR in this repo that have added the commit, must be GitHub bug.

@sudden6
Copy link

sudden6 commented Dec 24, 2017

@nurupo thanks for clarifying :)

@iphydf
Copy link
Member

iphydf commented Dec 27, 2017

Green :) let's make the release.

@robinlinden robinlinden merged commit fc0cc08 into TokTok:master Dec 27, 2017
@robinlinden robinlinden deleted the 0.1.11 branch August 13, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants