Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis #613

Merged
merged 4 commits into from
Nov 19, 2017
Merged

Fix travis #613

merged 4 commits into from
Nov 19, 2017

Conversation

Diadlo
Copy link

@Diadlo Diadlo commented Nov 13, 2017

This change is Reviewable

@Diadlo
Copy link
Author

Diadlo commented Nov 15, 2017

IPv6 is broken in Travis. Yey, it's not a toxcore issue!
travis-ci/travis-ci#8711

@TokTok TokTok deleted a comment from coveralls Nov 15, 2017
@Diadlo Diadlo changed the title [WIP] Fix travis Fix travis Nov 15, 2017
@sudden6
Copy link

sudden6 commented Nov 17, 2017

not very familiar with the autotools part, but the rest :lgtm_strong:


Reviewed 4 of 5 files at r1, 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@SkyzohKey SkyzohKey requested a review from iphydf November 19, 2017 22:25
@SkyzohKey SkyzohKey added CAT:coverage P1 High priority labels Nov 19, 2017
@SkyzohKey SkyzohKey removed the request for review from iphydf November 19, 2017 22:26
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 4 of 5 files at r1, 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@e0ff
Copy link
Member

e0ff commented Nov 19, 2017

:lgtm_strong:


Reviewed 4 of 5 files at r1, 8 of 8 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@robinlinden robinlinden merged commit 4d94a07 into TokTok:master Nov 19, 2017
@nurupo
Copy link
Member

nurupo commented Nov 25, 2017

I think the build flag and the define should have been named more explicitly as to hint that they enable/disable IPv6 only for tests, not for the entire toxcore.

@iphydf iphydf added this to the v0.2.0 milestone Jan 6, 2018
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
@iphydf iphydf added the test Adding missing tests, refactoring tests; no production code change label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority test Adding missing tests, refactoring tests; no production code change
Development

Successfully merging this pull request may close these issues.

7 participants