Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset hole-punching parameters after not punching for a while #574

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

zugz
Copy link

@zugz zugz commented Aug 5, 2017

This is an attempt to fix #237, based on a wild guess as to what might be going
on. Currently, if a friend goes offline and we try to reconnect to them, we
will continue the holepunching as if our initial attempt failed. It seems
likely that for many routers the first attempt, which tries ports close to
those which the friend's DHT neighbours report, is the one most likely to
succeed.

If this change does help with that issue, we should probably also tweak the
hole-punching algorithm to occasionally try close ports even if the first
attempt with them fails.


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2017

CLA assistant check
All committers have signed the CLA.

@robinlinden robinlinden added this to the v0.1.11 milestone Aug 5, 2017
@iphydf
Copy link
Member

iphydf commented Sep 13, 2017

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Sep 13, 2017

Please rebase and push.

@iphydf iphydf changed the title reset hole-punching parameters after not punching for a while Reset hole-punching parameters after not punching for a while Sep 15, 2017
@robinlinden
Copy link
Member

robinlinden commented Sep 17, 2017

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@robinlinden robinlinden merged commit 9e43d67 into TokTok:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Contacts are shown offline when they are online
4 participants