Reset hole-punching parameters after not punching for a while #574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #237, based on a wild guess as to what might be going
on. Currently, if a friend goes offline and we try to reconnect to them, we
will continue the holepunching as if our initial attempt failed. It seems
likely that for many routers the first attempt, which tries ports close to
those which the friend's DHT neighbours report, is the one most likely to
succeed.
If this change does help with that issue, we should probably also tweak the
hole-punching algorithm to occasionally try close ports even if the first
attempt with them fails.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)