Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a monolith_test that includes all toxcore sources. #554

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jun 4, 2017

This requires that every symbol, even if static (file-scope), is unique.
The idea is that we can easily run "whole" program static analysis on
programs that include monolith.h ("whole" is in quotes, as we don't
include dependencies like libsodium in this static analysis).


This change is Reviewable

@iphydf iphydf added this to the v0.1.9 milestone Jun 4, 2017
@iphydf iphydf force-pushed the monolith branch 2 times, most recently from 575b11a to b96438a Compare June 4, 2017 17:39
This requires that every symbol, even if static (file-scope), is unique.
The idea is that we can easily run "whole" program static analysis on
programs that include monolith.h ("whole" is in quotes, as we don't
include dependencies like libsodium in this static analysis).
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 1e8fa85 into TokTok:master Jun 4, 2017
@iphydf iphydf deleted the monolith branch June 4, 2017 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants