Portability Fixes

[Zer0-One]

This reverts commit 59e2a84.

• CFLAG gnu99 was changed to c99.
• CXXFLAG c++98 was changed to c++11.
• CFLAG -pedantic-errors was added so that non-ISO C now throws errors.
• _XOPEN_SOURCE feature test macro added and set to 600 to expose SUSv3 and c99 definitions in modules that required them.
• Fixed tests (and bootstrap daemon logging) that were failing due to the altered build flags.
• Avoid string suffix misinterpretation; explicit narrowing conversion.
• Misc. additions to .gitignore to make sure build artifacts don't wind up in version control.

---

This change is 

[iphydf]

_DARWIN_C_SOURCE may be needed for osx in network.c.

[Zer0-One]

@iphydf yeah, i noticed that sys/socket.h is included for macos, but that SO_NOSIGPIPE still isn't defined.

[Zer0-One]

I want to take a look at an actual os x install to be sure, but I don't have one :(

[jin-eld]

Afaik you need to add conditions to the code using #if defined(SO_NOSIGPIPE) so you do not use it at all on OSX, because it really is not available on OSX (and on BSD too I think?). I remember that from my MediaTomb times which was very portable and which we had running on pretty much every linux/unix system.

[Zer0-One]

@jin-eld I think you've got it backward. SO_NOSIGPIPE is a macos and bsd thing, not available on linux, and definitely not defined in POSIX. i haven't looked at it yet, but i'd guess the issue is a missing feature-test macro, like iphy suggested.

[jin-eld]

@Zer0-One Ooops :) Sorry... I guess it's been too long... somehow I remembered it the other way around.

[iphydf]

I assume you moved this block so you don't need an extra block at the beginning. Would it work if you moved this block back to where it came from and #define _DARWIN_C_SOURCE unconditionally together with _XOPEN_SOURCE?

[Zer0-One]

done

[iphydf]

if you squash the commits I'll merge it. Sorting the feature test macros (darwin before xopen) would be nice, but it's ok if you can't do that now.

---

Review status: 0 of 27 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[Zer0-One]

done and done

---

Review status: 0 of 27 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[nurupo]

---

Comments from Reviewable

[nurupo]

CMakeLists.txt, line 59 at r2 (raw file):

  add_cxxflag(${flag})
endmacro()
  

Remove the trailing whitespace.

---

Comments from Reviewable