Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more logging to TCP connection constructor. #2825

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 10, 2025

Also add more asserts to the test so we don't do UB.


This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Jan 10, 2025
@github-actions github-actions bot added the test Adding missing tests, refactoring tests; no production code change label Jan 10, 2025
@iphydf iphydf force-pushed the tcp-logging branch 4 times, most recently from 325f783 to 3f606d3 Compare January 10, 2025 22:11
Also add more asserts to the test so we don't do UB.
@iphydf iphydf marked this pull request as ready for review January 11, 2025 00:11
@iphydf iphydf requested a review from a team as a code owner January 11, 2025 00:11
@toktok-releaser toktok-releaser merged commit 380dde9 into TokTok:master Jan 11, 2025
63 checks passed
@iphydf iphydf deleted the tcp-logging branch January 11, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests, refactoring tests; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants