Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Reduce stack frame sizes to below 4096 bytes. #2823

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 5, 2025

This is currently only detectable in tests, because the main code uses VLAs where stack frame size is unknown at compile time.


This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Jan 5, 2025
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Jan 5, 2025
This is currently only detectable in tests, because the main code uses
VLAs where stack frame size is unknown at compile time.
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (52a2c1a) to head (0f12f38).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
- Coverage   72.90%   72.75%   -0.15%     
==========================================
  Files         150      150              
  Lines       30706    30707       +1     
==========================================
- Hits        22385    22341      -44     
- Misses       8321     8366      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toktok-releaser toktok-releaser merged commit 0f12f38 into TokTok:master Jan 6, 2025
65 checks passed
@iphydf iphydf deleted the stack-frame branch January 6, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants