cleanup: Fix all -Wsign-compare warnings.
#2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cleanup
JFreegman
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Reviewed 13 of 15 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
sign-compare
branch
2 times, most recently
from
8f0fe93 to
211a7ab
Compare
Green-Sky
reviewed
Nov 8, 2024
Green-Sky
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is