Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong comment for closelist #2785

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Nov 8, 2024

This change is Reviewable

@Green-Sky Green-Sky added this to the v0.2.20 milestone Nov 8, 2024
@Green-Sky Green-Sky added the documentation Changes to the documentation label Nov 8, 2024
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @Green-Sky)


toxcore/tox_private.h line 165 at r1 (raw file):

/**
 * This function returns the number of DHT nodes in the closelist,

The comma should be removed after "closelist", and "capable to store" should be "capable of storing".

Copy link
Member Author

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @JFreegman from a discussion.
Reviewable status: :shipit: complete! 1 change requests, 1 of 1 approvals obtained


toxcore/tox_private.h line 165 at r1 (raw file):

Previously, JFreegman wrote…

The comma should be removed after "closelist", and "capable to store" should be "capable of storing".

done

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@github-actions github-actions bot added the bug Bug fix for the user, not a fix to a build script label Nov 8, 2024
@Green-Sky Green-Sky force-pushed the fix_closelist_comment branch from 8324385 to 6d27a1a Compare November 8, 2024 18:38
@toktok-releaser toktok-releaser merged commit 6d27a1a into TokTok:master Nov 8, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script documentation Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants