-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong comment for closelist #2785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @Green-Sky)
toxcore/tox_private.h
line 165 at r1 (raw file):
/** * This function returns the number of DHT nodes in the closelist,
The comma should be removed after "closelist", and "capable to store" should be "capable of storing".
aeb059a
to
8324385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @JFreegman from a discussion.
Reviewable status: complete! 1 change requests, 1 of 1 approvals obtained
toxcore/tox_private.h
line 165 at r1 (raw file):
Previously, JFreegman wrote…
The comma should be removed after "closelist", and "capable to store" should be "capable of storing".
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
8324385
to
6d27a1a
Compare
This change is