Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: friend_connections leak on allocation failure. #2772

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Oct 10, 2024

clean up when it only contains connections in the NONE state.
rare in practice, found by fuzzing


This change is Reviewable

@Green-Sky Green-Sky added bug Bug fix for the user, not a fix to a build script P3 Low priority labels Oct 10, 2024
@Green-Sky Green-Sky added this to the v0.2.20 milestone Oct 10, 2024
@Green-Sky Green-Sky force-pushed the fix_friend_con_leak1 branch 2 times, most recently from 1825cdd to 7a5c509 Compare November 8, 2024 13:50
@Green-Sky Green-Sky force-pushed the fix_friend_con_leak1 branch 2 times, most recently from 7c28b12 to 50149a9 Compare November 8, 2024 16:17
clean up when it only contains connections in the NONE state
@Green-Sky Green-Sky force-pushed the fix_friend_con_leak1 branch from 50149a9 to 5f88a08 Compare November 8, 2024 19:08
@iphydf iphydf changed the title fix: friend_connections leak on allocation failure fix: friend_connections leak on allocation failure. Nov 8, 2024
@toktok-releaser toktok-releaser merged commit 5f88a08 into TokTok:master Nov 8, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script P3 Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants