-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: events leak that can occur if allocation fails #2771
fix: events leak that can occur if allocation fails #2771
Conversation
d0cd28b
to
1fabce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 40 of 40 files at r1, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
Not sure how we should fix the mallocfail test. the send message autotest times out, be cause the event fails to allocate and thus gets dropped. |
Well, the allocation failure is propagated to the test code via |
Actually, scratch that. Reading mallocfail's README, the intended use is to not modify the code to accommodate the use of mallocfail, but to keep re-running it with mallocfail many times until no new entries are added to mallocfail's hashes file, at which point all mallocs will succeed and the test should succeed too, keeping note of unusual terminations/crashes along the way. |
1fabce5
to
15ca352
Compare
for reference #2783 was a fix specifically for the ci fail. |
rare in practice, found by fuzzing
15ca352
to
4067628
Compare
rare in practice, found by fuzzing
This change is