Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in GroupAV #275

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Fix a memory leak in GroupAV #275

merged 1 commit into from
Nov 21, 2016

Conversation

nurupo
Copy link
Member

@nurupo nurupo commented Nov 15, 2016

Clang's scan-build has identified two potential memory leaks in groupav.c. Looks like there were cases when the decode_audio_packet() function would return without freeing the allocated memory, which is fixed by this PR.


This change is Reviewable

@nurupo nurupo added bug Bug fix for the user, not a fix to a build script toxav Audio/video labels Nov 15, 2016
@nurupo nurupo added this to the v0.0.5 milestone Nov 15, 2016
@iphydf
Copy link
Member

iphydf commented Nov 15, 2016

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


toxav/groupav.c, line 373 at r1 (raw file):

        if (out_audio_samples <= 0) {
            free(out_audio);

(I love me some code duplication..)


Comments from Reviewable

@GrayHatter
Copy link

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@iphydf iphydf merged commit 551660a into TokTok:master Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script toxav Audio/video
Development

Successfully merging this pull request may close these issues.

4 participants