refactor: Make prune_gc_sanctions_list more obviously correct. #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2658 +/- ##
==========================================
+ Coverage 73.76% 73.77% +0.01%
==========================================
Files 148 148
Lines 30479 30476 -3
==========================================
+ Hits 22484 22485 +1
+ Misses 7995 7991 -4 ☔ View full report in Codecov by Sentry. |
JFreegman
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
`target_ext_pk` is uninitialised before the loop, and is definitely initialised after the loop *iff* `sanction` isn't NULL. If it is NULL, then `target_ext_pk` is not read. This is verifiable, but not obvious. PVS Studio isn't smart enough to figure that out, so it complains. I consider it a valid complaint, and the new code is clearer: we now call the processing part of the function directly with initialised values instead of relying on that initialisation coinciding with `sanction`s nullity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_ext_pkis uninitialised before the loop, and is definitely initialised after the loop iffsanctionisn't NULL. If it is NULL, thentarget_ext_pkis not read. This is verifiable, but not obvious. PVS Studio isn't smart enough to figure that out, so it complains. I consider it a valid complaint, and the new code is clearer: we now call the processing part of the function directly with initialised values instead of relying on that initialisation coinciding withsanctions nullity.This change is