-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make ToxAV independent of toxcore internals. #2651
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
==========================================
- Coverage 73.08% 73.04% -0.04%
==========================================
Files 149 149
Lines 30531 30478 -53
==========================================
- Hits 22313 22263 -50
+ Misses 8218 8215 -3 ☔ View full report in Codecov by Sentry. |
e59814d
to
8a4092b
Compare
This is ready for review. |
8a4092b
to
55a8294
Compare
e0896da
to
756ee54
Compare
eb8a05a
to
5b737a8
Compare
5b737a8
to
59d3feb
Compare
664ee5f
to
560cd96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toxav_old.c
uses the Messenger
logger, instead the ToxAV
logger.
edit: I see that they are still more tightly coupled to messenger and conferences. Maybe we just remove them for v0.3 ?
dac5f88
to
d4978a3
Compare
d4978a3
to
3297b62
Compare
@Green-Sky "m_lossy_rtp_packet_cb" is actually a leftover that should be deleted. same as "RTP_Packet_Handler" |
f02b881
to
be10b4c
Compare
True, fixed. |
@Green-Sky mergeable is failing because of the commit messages missing "refactor" or similar |
Yes, that is going to go away when I squash this pr. |
be10b4c
to
e99b171
Compare
e99b171
to
c4cdea6
Compare
c4cdea6
to
717aefe
Compare
717aefe
to
a57c2c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 26 files at r1, 3 of 4 files at r2, 3 of 5 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @goldroom and @Green-Sky)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 26 files at r1, 3 of 4 files at r2, 3 of 5 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @goldroom)
closes #1431
This change is