refactor: Use merge_sort instead of qsort for sorting.

[iphydf]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 93.78531% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.13%. Comparing base (956cd08) to head (a749ee7).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
toxcore/DHT.c	92.10%	3 Missing ⚠️
toxcore/group.c	85.00%	3 Missing ⚠️
toxcore/sort.c	95.38%	3 Missing ⚠️
toxcore/onion_client.c	92.59%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
- Coverage   73.21%   73.13%   -0.09%     
==========================================
  Files         149      150       +1     
  Lines       30595    30702     +107     
==========================================
+ Hits        22401    22454      +53     
- Misses       8194     8248      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JFreegman]

What are the advantages of merge sort over qsort in this instance?

[iphydf]

What are the advantages of merge sort over qsort in this instance?

https://github.com/TokTok/c-toxcore/pull/2638/files#diff-421ac668286fc646ef81a78b41a2b05bb4c1dbf1f02f3ed69ced2929a8ba4e10R141-R145

I guess I can explain more in that comment if needed. This PR is part of my attempt to make toxcore C code rely less on struct layouts and low level system properties and be semantically simpler. I know C coders like to bit-twiddle everything, but I think it's worth trying to avoid that as much as possible. qsort operates with memcpy, lots of casting from and to char*, moving around in abstract memory with pointer arithmetic, etc. It's semantically complex and requires complicated abstract domains that understand memory layouts and their implications.

[iphydf]

As for why merge sort instead of any other algorithm: it's an easy one to implement and has deterministic time complexity. If we have a lot of mostly-sorted arrays, we should probably just sorted-insert elements rather than adding a bunch of unsorted elements and sorting afterwards.

[Green-Sky]

with qsort gone, are we still using anything from stdlib.h ?

[iphydf]

with qsort gone, are we still using anything from stdlib.h ?

Only in group.c. I've removed it from the other 2.

[Green-Sky]

and onion_announce.c ?

[iphydf]

and onion_announce.c ?

Done.