-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Only check the bootstrap daemon checksum on release. #2620
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2620 +/- ##
==========================================
- Coverage 73.71% 73.65% -0.06%
==========================================
Files 148 148
Lines 30407 30407
==========================================
- Hits 22413 22396 -17
- Misses 7994 8011 +17 ☔ View full report in Codecov by Sentry. |
dfbc814
to
45195fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this? Replacing sha256sum
with a no-op echo
is a bit weird, keeping sha256sum
and just turning it off/on with true
and false
shell built-ins seems more proper, no?
48b395b
to
5dbd657
Compare
That broke it. Do you want to fix it or should I? |
Right, it interprets Let's just keep your version then, don't think it's worth fixing mine. |
5dbd657
to
45195fe
Compare
It's pure toil until then. It's only interesting as part of the release checklist, not in regular PRs.
45195fe
to
8d29935
Compare
It's pure toil until then. It's only interesting as part of the release checklist, not in regular PRs.
This change is