Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only check the bootstrap daemon checksum on release. #2620

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 31, 2024

It's pure toil until then. It's only interesting as part of the release checklist, not in regular PRs.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f70e588) 73.71% compared to head (8d29935) 73.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2620      +/-   ##
==========================================
- Coverage   73.71%   73.65%   -0.06%     
==========================================
  Files         148      148              
  Lines       30407    30407              
==========================================
- Hits        22413    22396      -17     
- Misses       7994     8011      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the shasum-on-release branch 2 times, most recently from dfbc814 to 45195fe Compare January 31, 2024 18:25
@iphydf iphydf marked this pull request as ready for review January 31, 2024 18:26
@iphydf iphydf requested a review from a team as a code owner January 31, 2024 18:26
@nurupo nurupo self-requested a review January 31, 2024 18:58
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? Replacing sha256sum with a no-op echo is a bit weird, keeping sha256sum and just turning it off/on with true and false shell built-ins seems more proper, no?

@pull-request-attention pull-request-attention bot assigned iphydf and unassigned nurupo Jan 31, 2024
@nurupo nurupo force-pushed the shasum-on-release branch from 48b395b to 5dbd657 Compare January 31, 2024 19:17
@iphydf
Copy link
Member Author

iphydf commented Jan 31, 2024

How about this? Replacing sha256sum with a no-op echo is a bit weird, keeping sha256sum and just turning it off/on with true and false shell built-ins seems more proper, no?

That broke it. Do you want to fix it or should I?

@nurupo
Copy link
Member

nurupo commented Jan 31, 2024

Right, it interprets false's exit code as an error.

Let's just keep your version then, don't think it's worth fixing mine.

@nurupo nurupo force-pushed the shasum-on-release branch from 5dbd657 to 45195fe Compare January 31, 2024 20:14
It's pure toil until then. It's only interesting as part of the release
checklist, not in regular PRs.
@iphydf iphydf force-pushed the shasum-on-release branch from 45195fe to 8d29935 Compare January 31, 2024 20:40
@toktok-releaser toktok-releaser merged commit 8d29935 into TokTok:master Jan 31, 2024
58 checks passed
@iphydf iphydf deleted the shasum-on-release branch January 31, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants