cleanup: Remove plan9 support. #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
no-plan9
branch
3 times, most recently
from
0efafd5 to
d010db8
Compare
nurupo
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM.
Tagging @netbsduser in case they want to make a PR bringing it back, with a working CI check for Plan 9. We have FreeBSD running in qemu as a CI check, which might be useful as a reference.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
==========================================
- Coverage 73.66% 73.63% -0.04%
==========================================
Files 148 148
Lines 30315 30315
==========================================
- Hits 22332 22321 -11
- Misses 7983 7994 +11 ☔ View full report in Codecov by Sentry. |
We really don't support it. I tried for half an hour to get some kind of plan9 cross compilation to work, but it's not working. If anyone wants to bring it back, they are welcome to send a PR including a CI check for it. Until then, these 5 lines of unused code are gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really don't support it. I tried for half an hour to get some kind of plan9 cross compilation to work, but it's not working. If anyone wants to bring it back, they are welcome to send a PR including a CI check for it. Until then, these 5 lines of unused code are gone.
This change is