fix: issues with packet broadcast error reporting #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
force-pushed
the
group_send_error_fix
branch
4 times, most recently
from
f7ba009 to
4ea38ec
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 69.02% 69.02% -0.01%
==========================================
Files 96 96
Lines 28049 28054 +5
==========================================
+ Hits 19362 19364 +2
- Misses 8687 8690 +3 ☔ View full report in Codecov by Sentry. |
JFreegman
force-pushed
the
group_send_error_fix
branch
from
e09a230 to
01608a1
Compare
Green-Sky
approved these changes
Jan 11, 2024
commit 5b9c420 introduced some undesirable behaviour with packet send functions returning error when they shouldn't. We now only return an error if the packet fails to be added to the send queue or cannot be wrapped/encrypted. We no longer error if we fail to send the packet over the wire, because toxcore will keep trying to re-send the packet until the connection times out. Additionally, we now make sure that our packet broadcast functions aren't returning an error when failing to send packets to peers that we have not successfully handshaked with yet, since this is expected behaviour.
JFreegman
force-pushed
the
group_send_error_fix
branch
from
01608a1 to
072e3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 5b9c420 introduced some undesirable behaviour with packet send functions returning error when they shouldn't. We now only return an error if the packet fails to be added to the send queue or cannot be wrapped/encrypted. We no longer error if we fail to send the packet over the wire, because toxcore will keep trying to re-send the packet until the connection times out.
Additionally, we now make sure that our packet broadcast functions aren't returning an error when failing to send packets to peers that we have not successfully handshaked with yet, since this is expected behaviour.
This change is