Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Move tox_get_system out of the public API. #2523

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 5, 2024

It's not released, yet, and this function is a pain. We don't want it going forward.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 5, 2024
@iphydf iphydf marked this pull request as ready for review January 5, 2024 17:14
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9ca400) 68.99% compared to head (5cac6d7) 68.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2523      +/-   ##
==========================================
- Coverage   68.99%   68.96%   -0.03%     
==========================================
  Files          89       89              
  Lines       27782    27782              
==========================================
- Hits        19167    19160       -7     
- Misses       8615     8622       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the definition is in private, there is no real way to define a custom system with just tox.h anyway.

It's not released, yet, and this function is a pain. We don't want it
going forward.
@toktok-releaser toktok-releaser merged commit 5cac6d7 into TokTok:master Jan 5, 2024
52 checks passed
@iphydf iphydf deleted the private-system branch January 5, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants