Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove NaCl support. #2497

Merged
merged 1 commit into from
Dec 25, 2023

cleanup: Remove NaCl support.

895a6af
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Remove NaCl support. #2497

cleanup: Remove NaCl support.
895a6af
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 25, 2023 in 1s

2 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Remove NaCl support.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : We now depend on libsodium unconditionally. Future work will require functions from libsodium, and nobody we're aware of uses the nacl build for anything other than making sure it still works on CI.

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}