Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add check-c run to bazel build. #2470

Merged
merged 1 commit into from
Dec 16, 2023
Merged

test: Add check-c run to bazel build. #2470

merged 1 commit into from
Dec 16, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 15, 2023

Makes iterating on both check-c and the toxcore code easier.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15ee46d) 71.65% compared to head (89b6450) 71.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
+ Coverage   71.65%   71.74%   +0.09%     
==========================================
  Files          75       75              
  Lines       25200    25200              
==========================================
+ Hits        18056    18079      +23     
+ Misses       7144     7121      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makes iterating on both check-c and the toxcore code easier.
@iphydf iphydf marked this pull request as ready for review December 15, 2023 23:09
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit 89b6450 into TokTok:master Dec 16, 2023
37 of 38 checks passed
@iphydf iphydf deleted the check-c branch December 16, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants