Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable debug flag for ubsan. #2459

Merged
merged 1 commit into from
Dec 9, 2023
Merged

fix: Enable debug flag for ubsan. #2459

merged 1 commit into from
Dec 9, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 8, 2023

Otherwise the nullability annotations are compiled out in attributes.h.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 8, 2023
@iphydf iphydf force-pushed the ubsan branch 2 times, most recently from 8238f31 to cc9df70 Compare December 9, 2023 00:13
@iphydf iphydf force-pushed the ubsan branch 3 times, most recently from a67bd5a to e48731a Compare December 9, 2023 00:59
@iphydf iphydf force-pushed the ubsan branch 3 times, most recently from 8f8e973 to 6a80726 Compare December 9, 2023 01:08
@iphydf iphydf marked this pull request as ready for review December 9, 2023 01:12
Otherwise the nullability annotations are compiled out in attributes.h.
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (4d1db21) 74.48% compared to head (3983369) 74.36%.

Files Patch % Lines
toxcore/tox_unpack.c 39.39% 20 Missing ⚠️
toxcore/Messenger.c 66.66% 4 Missing ⚠️
toxcore/group_pack.c 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2459      +/-   ##
==========================================
- Coverage   74.48%   74.36%   -0.12%     
==========================================
  Files          87       87              
  Lines       26265    26313      +48     
==========================================
+ Hits        19563    19568       +5     
- Misses       6702     6745      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf merged commit 3983369 into TokTok:master Dec 9, 2023
37 of 38 checks passed
@iphydf iphydf deleted the ubsan branch December 9, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants