test: Add an s390x build (on alpine) for CI. #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
approved these changes
Nov 22, 2023
JFreegman
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
iphydf
force-pushed
the
s390x
branch
2 times, most recently
from
dd318ad to
2d01095
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2429 +/- ##
==========================================
- Coverage 74.51% 74.47% -0.05%
==========================================
Files 87 87
Lines 26244 26244
==========================================
- Hits 19556 19545 -11
- Misses 6688 6699 +11 ☔ View full report in Codecov by Sentry. |
nurupo
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
nurupo
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Reviewed 19 of 22 files at r1.
Reviewable status:
iphydf
force-pushed
the
s390x
branch
2 times, most recently
from
bc0b0fe to
f11890f
Compare
It doesn't work at all, because we're missing something in the net code to do with endian conversions. I haven't investigated, yet, but at least now we have a failing test that can be investigated. Also moved to cmake 3.5 at minimum. CMake will stop supporting lower versions than that, soon. Also moved to C11 from C99 to get `static_assert`. Also made a network ERROR into a WARNING. It triggers on FreeBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work at all, because we're missing something in the net code to do with endian conversions. I haven't investigated, yet, but at least now we have a failing test that can be investigated.
Also moved to cmake 3.5 at minimum. CMake will stop supporting lower versions than that, soon.
Also moved to C11 from C99 to get
static_assert.This change is