refactor: Use Bin_Pack for packing Node_format. #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2420 +/- ##
==========================================
+ Coverage 74.35% 74.39% +0.03%
==========================================
Files 87 87
Lines 26255 26264 +9
==========================================
+ Hits 19522 19539 +17
+ Misses 6733 6725 -8 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
pack-nodes
branch
9 times, most recently
from
ac0a70e to
27bea3f
Compare
JFreegman
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
Reviewed 7 of 10 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is