Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more logging to loading conferences from savedata. #2416

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 8, 2023

Better error messages than "something went wrong in type 20".


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 8, 2023
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Better error messages than "something went wrong in type 20".

Also fix bazel-asan/tsan builds.

tweag/rules_nixpkgs#442 is blocking fuzz
tests under asan.
@iphydf iphydf changed the title chore: Add more logging to loading conferences from savedata. chore: Add more logging to loading conferences from savedata Nov 8, 2023
@iphydf iphydf changed the title chore: Add more logging to loading conferences from savedata chore: Add more logging to loading conferences from savedata. Nov 8, 2023
@iphydf iphydf merged commit 6be29f0 into TokTok:master Nov 8, 2023
33 of 34 checks passed
@iphydf iphydf deleted the logging-load branch November 8, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants