-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for larger incoming NGC packets #2380
feat: allow for larger incoming NGC packets #2380
Conversation
What's the purpose of this and when would it be applicable? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2380 +/- ##
==========================================
- Coverage 74.51% 74.43% -0.08%
==========================================
Files 87 87
Lines 26241 26243 +2
==========================================
- Hits 19554 19535 -19
- Misses 6687 6708 +21 ☔ View full report in Codecov by Sentry. |
It might make sense to make toxcore generally more accepting of incoming packets up to some size (e.g. 1500 bytes). On Ethernet, we'll never get that kind of packet size, but it's not bad to be lenient on the inbound packet size. We still need some limit to avoid DoS, but 1500 seems reasonable for any packet processor functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incoming packet sizes should generally be quite accepting. We should not allow arbitrary sizes (because DoS), but something upwards of MTU makes sense.
d38664f
to
b7bca61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
b7bca61
to
cd34b60
Compare
This change is